Re: [PATCH 2/2] MIPS: kprobes: Massage previous delay slot detection

From: Thomas Bogendoerfer
Date: Tue Sep 10 2024 - 07:16:19 EST


On Tue, Sep 10, 2024 at 10:43:23AM +0100, Jiaxun Yang wrote:
>
>
> 在2024年9月9日九月 下午11:02,Maciej W. Rozycki写道:
> > On Sun, 8 Sep 2024, Jiaxun Yang wrote:
> >
> >> Expand the if condition into cascaded ifs to make code
> >> readable.
> >
> > Apart from broken formatting what's making original code unreadable?
>
> For me it's confusing because wired layout, cascaded ifs are clearly
> easier to format and has clear intention.

I prefer the original version, it's just to statements combined with &&,
which isn't scary at all.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]