Re: [PATCH v8] i2c: designware: fix master is holding SCL low while ENABLE bit is disabled

From: Jarkko Nikula
Date: Tue Sep 10 2024 - 07:20:59 EST


On 9/10/24 12:38 PM, Liu Kimriver/刘金河 wrote:
Hi Andy,

-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Sent: 2024年9月10日 17:03
To: Liu Kimriver/刘金河 <kimriver.liu@xxxxxxxxxxxx>
Cc: jarkko.nikula@xxxxxxxxxxxxxxx; mika.westerberg@xxxxxxxxxxxxxxx; jsd@xxxxxxxxxxxx; andi.shyti@xxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
Subject: Re: [PATCH v8] i2c: designware: fix master is holding SCL low while ENABLE bit is disabled

On Tue, Sep 10, 2024 at 02:13:09PM +0800, Kimriver Liu wrote:
It was observed issuing ABORT bit(IC_ENABLE[1]) will not work when

"...observed that issuing..."
...bit (..."


IC_ENABLE is already disabled.

Check if ENABLE bit(IC_ENABLE[0]) is disabled when the master is

"...bit (..."
master --> controller

Update it in V9

Please add back also kernel errors that are shown when the issue occurs. I saw those mentioned in the commit log in some earlier version of the patch.

Those may help googling the solution (i.e. this patch) if somebody sees similar error on their HW.