Re: [RESEND PATCH v3] sysctl: simplify the min/max boundary check

From: Joel Granados
Date: Tue Sep 10 2024 - 08:08:31 EST


On Thu, Sep 05, 2024 at 09:48:18PM +0800, Wen Yang wrote:
> The do_proc_dointvec_minmax_conv_param structure provides the minimum and
> maximum values for doing range checking for the proc_dointvec_minmax()
> handler, while the do_proc_douintvec_minmax_conv_param structure also
> provides these min/max values for doing range checking for the
> proc_douintvec_minmax()/proc_dou8vec_minmax() handlers.
>
> To avoid duplicate code, a new proc_minmax_conv_param structure has been
> introduced to replace both do_proc_dointvec_minmax_conv_param and
> do_proc_douintvec_minmax_conv_param mentioned above.
>
> This also prepares for the removal of sysctl_vals and sysctl_long_vals.
>
> Signed-off-by: Wen Yang <wen.yang@xxxxxxxxx>
> Cc: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
> Cc: Joel Granados <j.granados@xxxxxxxxxxx>
> Cc: Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
> Cc: Christian Brauner <brauner@xxxxxxxxxx>
> Cc: Dave Young <dyoung@xxxxxxxxxx>
> Cc: linux-kernel@xxxxxxxxxxxxxxx
Thx for the remind. Its a bit to late to include this for 6.12. Will put it in
sysctl-testing setting it up for 6.13 (or whatever the next version will be).

Best

--

Joel Granados