Re: [PATCH V9 net-next 03/11] net: hibmcge: Add mdio and hardware configuration supported in this module

From: Jijie Shao
Date: Tue Sep 10 2024 - 09:54:19 EST



on 2024/9/10 20:21, Andrew Lunn wrote:
On Tue, Sep 10, 2024 at 03:59:34PM +0800, Jijie Shao wrote:
this driver using phy through genphy device.
As far as i can see, there is nothing here which limits you to
genphy. The hardware could use any PHY driver which phylib has. In
general, we don't recommend genphy, it is just a fallback driver which
might work, but given the complexity of modern PHYs, also might not.

What PHY do you actually have on the board?

Andrew

We use YT8521,phylib already has this driver.
Therefore, when CONFIG_MOTORCOMM_PHY is enabled, the PHY driver is automatically used.

Thuis description is a bit misleading and I'll fix it in the next version.
I think I might need to add a dependency on CONFIG_MOTORCOMM_PHY in Kconfig

Thanks
Jijie Shao