Re: [PATCH V9 net-next 05/11] net: hibmcge: Implement some .ndo functions

[Jijie Shao]

on 2024/9/10 20:34, Andrew Lunn wrote:
> On Tue, Sep 10, 2024 at 03:59:36PM +0800, Jijie Shao wrote:
> > +
> > @@ -88,6 +181,10 @@ static int hbg_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
> >   	if (ret)
> >   		return ret;
> >   
> > +	netdev->max_mtu = priv->dev_specs.max_mtu;
> > +	netdev->min_mtu = priv->dev_specs.min_mtu;
> > +	hbg_change_mtu(priv, HBG_DEFAULT_MTU_SIZE);
> It does not help that you added added HBG_DEFAULT_MTU_SIZE in a
> previous patch, but as far as i see, it is just ETH_DATA_LEN.
>
> Please use the standard defines, rather than adding your own. It makes
> the code a lot easier to understand, it is not using some special
> jumbo size by default, it is just the plain, boring, normal 1500
> bytes.
>
>      Andrew
The value of HBG_DEFAULT_MTU_SIZE is also 1500.
So，ETH_DATA_LEN can also be used.

Sorry I didn't notice ETH_DATA_LEN  before, I'll use it in V10.

Thanks,
	Jijie Shao