Re: [PATCH v5] dts: nxp: mxs: Add descriptions for imx287 based btt3-[012] devices

[Rob Herring]

On Tue, Sep 10, 2024 at 5:23 AM Lukasz Majewski <lukma@xxxxxxx> wrote:
>
> The btt3 device' HW revisions from 0 to 2 use imx287 SoC and are to
> some extend similar to already upstreamed XEA devices, hence are
> using common imx28-lwe.dtsi file.
>
> New, imx28-btt3.dtsi file has been added to embrace common DTS
> properties for different HW revisions for this device.
>
> As a result - changes introduced in imx28-btt3-[012].dts are
> minimal.
>
> This patch also adds entry to fsl.yaml for btt3 board.
>
> Signed-off-by: Lukasz Majewski <lukma@xxxxxxx>
>
> ---
> Changes for v2:
> - Rename dts file from btt3-[012] to imx28-btt3-[012] to match current
>   linux kernel naming convention
> - Remove 'wlf,wm8974' from compatible for codec@1a
>
> Changes for v3:
> - Keep alphabethical order for Makefile entries
>
> Changes for v4:
> - Change compatible for btt3 board (to 'lwn,imx28-btt3')
>
> Changes for v5:
> - Combine patch, which adds btt3-[012] with one adding board entry to
>   fsl.yaml
> ---
>  .../devicetree/bindings/arm/fsl.yaml          |   1 +

I said 1 series, not 1 patch. checkpatch.pl will also tell you
bindings should be a separate patch.

>  arch/arm/boot/dts/nxp/mxs/Makefile            |   3 +
>  arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts    |  12 +
>  arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts    |   8 +
>  arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts    |  12 +
>  arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi     | 320 ++++++++++++++++++
>  6 files changed, 356 insertions(+)
>  create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-0.dts
>  create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-1.dts
>  create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3-2.dts
>  create mode 100644 arch/arm/boot/dts/nxp/mxs/imx28-btt3.dtsi