Re: [PATCH 3/3] arm64: dts: imx93-9x9-qsb: Add PDM microphone sound card support

[Frank Li]

On Tue, Sep 10, 2024 at 03:19:32PM +0800, Shengjiu Wang wrote:
> Add PDM micphone sound card support, configure the pinmux.
>
> This sound card supports recording sound from PDM microphone
> and convert the PDM format data to PCM data.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@xxxxxxx>
> ---
>  .../boot/dts/freescale/imx93-9x9-qsb.dts      | 35 +++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
> index d213a5343803..1340f5462d11 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
> +++ b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
> @@ -122,6 +122,18 @@ simple-audio-card,codec {
>  		};
>  	};
>
> +	sound-micfil {
> +		compatible = "fsl,imx-audio-card";
> +		model = "micfil-audio";
> +		pri-dai-link {
> +			link-name = "micfil hifi";
> +			format = "i2s";
> +			cpu {
> +				sound-dai = <&micfil>;
> +			};
> +		};
> +	};
> +
>  	sound-wm8962 {
>  		compatible = "fsl,imx-audio-wm8962";
>  		model = "wm8962-audio";
> @@ -266,6 +278,12 @@ pcal6524: gpio@22 {
>  		pinctrl-names = "default";
>  		pinctrl-0 = <&pinctrl_pcal6524>;
>
> +		mic-can-sel-hog {
> +			gpio-hog;
> +			gpios = <17 GPIO_ACTIVE_HIGH>;
> +			output-low;
> +		};
> +

sort nodename, it should after exp-sel-hog.

>  		exp-sel-hog {
>  			gpio-hog;
>  			gpios = <22 GPIO_ACTIVE_HIGH>;
> @@ -355,6 +373,15 @@ &lpuart1 { /* console */
>  	status = "okay";
>  };
>
> +&micfil {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pdm>;
> +	assigned-clocks = <&clk IMX93_CLK_PDM>;
> +	assigned-clock-parents = <&clk IMX93_CLK_AUDIO_PLL>;
> +	assigned-clock-rates = <49152000>;
> +	status = "okay";
> +};
> +
>  &mu1 {
>  	status = "okay";
>  };
> @@ -535,6 +562,14 @@ MX93_PAD_SD1_STROBE__USDHC1_STROBE	0x15fe
>  		>;
>  	};
>
> +	pinctrl_pdm: pdmgrp {
> +		fsl,pins = <
> +			MX93_PAD_PDM_CLK__PDM_CLK			0x31e
> +			MX93_PAD_PDM_BIT_STREAM0__PDM_BIT_STREAM00	0x31e
> +			MX93_PAD_PDM_BIT_STREAM1__PDM_BIT_STREAM01	0x31e
> +		>;
> +	};
> +

Does pdmgrp is ordered? look like it should be ahead of USDHC

Frank

>  	pinctrl_reg_usdhc2_vmmc: regusdhc2vmmcgrp {
>  		fsl,pins = <
>  			MX93_PAD_SD2_RESET_B__GPIO3_IO07	0x31e
> --
> 2.34.1
>