Re: [PATCH] block/blk-rq-qos: introduce macro RQ_QOS_FN for common behaviors in rq_qos*

[Bart Van Assche]

On 9/10/24 1:42 AM, chensong_2000@xxxxxx wrote:
> +#define RQ_QOS_FN(q, fn, ...)	\
> +	do {	\
> +		struct rq_qos *rqos;	\
> +		for_each_rqos(rqos, q)	\
> +			if (rqos->ops->fn)	\
> +				rqos->ops->fn(rqos, ##__VA_ARGS__);	\
> +	} while (0)

I'm not sure whether this patch is a step in the right direction. If
others agree with the approach of this patch, I think we need a better
name for this macro, e.g. CALL_RQ_QOS_FN().

Thanks,

Bart.