Re: [PATCH -next] PCI: altera: Replace TLP_REQ_ID() with macro PCI_DEVID()

[Krzysztof Wilczyński]

Hello,

[...]
> >  #define TLP_READ_TAG			0x1d
> >  #define TLP_WRITE_TAG			0x10
> >  #define RP_DEVFN			0
> > -#define TLP_REQ_ID(bus, devfn)		(((bus) << 8) | (devfn))
> >  #define TLP_CFG_DW0(pcie, cfg)		\
> >  		(((cfg) << 24) |	\
> >  		  TLP_PAYLOAD_SIZE)
> >  #define TLP_CFG_DW1(pcie, tag, be)	\
> > -	(((TLP_REQ_ID(pcie->root_bus_nr,  RP_DEVFN)) << 16) | (tag << 8) | (be))
> > +	(((PCI_DEVID(pcie->root_bus_nr,  RP_DEVFN)) << 16) | (tag << 8) | (be))
> 
> This doesn't cause a problem per se, but PCI_DEVID() is defined
> basically as a PCI core convenience without any particular connection
> to the PCIe Requester ID format, so I don't think this is an
> improvement.

I will drop this patch based on feedback from Bjorn.

	Krzysztof