Re: [PATCH V2] mm: Drop unused set_pte_safe()

[Andrew Morton]

On Tue, 10 Sep 2024 15:40:26 +0530 Anshuman Khandual <anshuman.khandual@xxxxxxx> wrote:

> All set_pte_safe() usage have been dropped after the commit eccd906484d1
> ("x86/mm: Do not use set_{pud, pmd}_safe() when splitting a large page")
> This just drops now unused helper set_pte_safe().
> 
> Besides this macro was buggy due to doing direct dereferencing of the pte,
> and if it were to be kept, it should have been updated to use a single call
> to ptep_get().
> 

arch/x86/mm/init_64.c: In function 'set_pte_init':
arch/x86/mm/init_64.c:83:17: error: implicit declaration of function 'set_pte_safe'; did you mean 'set_pmd_safe'? [-Werror=implicit-function-declaration]
   83 |                 set_##type1##_safe(arg1, arg2);                 \
      |                 ^~~~
arch/x86/mm/init_64.c:91:1: note: in expansion of macro 'DEFINE_ENTRY'
   91 | DEFINE_ENTRY(pte, pte, init)
      | ^~~~~~~~~~~~