Re: [PATCH v2 6/6] MIPS: cm: Probe GCR address from DeviceTree

[Serge Semin]

On Tue, Sep 10, 2024 at 09:48:10PM +0100, Jiaxun Yang wrote:
> 
> 
> 在2024年9月10日九月 下午9:07，Serge Semin写道：
> [...]
> > Both MIPS P5600 and P6600 databooks define the GCR_BASE field as
> > optionally R/W:
> >
> > GCR_BASE 31:15 This field sets the base address of the 32KB          R or R/W
> >                GCR block of the P5600 MPS.                           (IP Config-
> >                This register has a fixed value after reset if         uration)
> >                configured as Read-Only (an IP Configuration Option).
> >
> 

> Thanks for the pointer, I traced code history and it seems like MIPS decided
> to not expose this functionality at some point, but documents were not updated.

Got it. Thanks for clarification.

> 
> Maybe I should add a read back check here.

The check is already implemented in the mips_cm_probe() method. Just
10 lines below the mips_cm_phys_base() method call.

-Serge(y)

> 
> Thanks
> -- 
> - Jiaxun