[PATCH] ASoC: mt8365: Fix using uninitialized value "i2s_data" issue
From: Qianqiang Liu
Date: Tue Sep 10 2024 - 20:24:50 EST
The "i2s_data" might not be initialized before using it.
Set it to NULL by default and also check if it is valid.
Signed-off-by: Qianqiang Liu <qianqiang.liu@xxxxxxx>
---
sound/soc/mediatek/mt8365/mt8365-dai-i2s.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c b/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c
index 3482d8f8b4e7..3a8a5d975a04 100644
--- a/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c
+++ b/sound/soc/mediatek/mt8365/mt8365-dai-i2s.c
@@ -465,7 +465,7 @@ void mt8365_afe_set_i2s_out_enable(struct mtk_base_afe *afe, bool enable)
int i;
unsigned long flags;
struct mt8365_afe_private *afe_priv = afe->platform_priv;
- struct mtk_afe_i2s_priv *i2s_data;
+ struct mtk_afe_i2s_priv *i2s_data = NULL;
for (i = 0; i < DAI_I2S_NUM; i++) {
if (mt8365_i2s_priv[i].adda_link)
@@ -474,6 +474,11 @@ void mt8365_afe_set_i2s_out_enable(struct mtk_base_afe *afe, bool enable)
spin_lock_irqsave(&afe_priv->afe_ctrl_lock, flags);
+ if (!i2s_data) {
+ spin_unlock_irqrestore(&afe_priv->afe_ctrl_lock, flags);
+ return;
+ }
+
if (enable) {
i2s_data->i2s_out_on_ref_cnt++;
if (i2s_data->i2s_out_on_ref_cnt == 1)
--
2.39.2