Re: [PATCH] mm: remove redundant if overhead

[zhiguojiang]

在 2024/9/11 0:03, Matthew Wilcox 写道:
> On Tue, Sep 10, 2024 at 10:39:45PM +0800, Zhiguo Jiang wrote:
> > Remove redundant if judgment overhead.
> It's not redundant; it avoids dirtying the cacheline if the folio
> is already marked as dirty.
Ok, Is it necessary to add comments here to explain and avoid readers'
misunderstandings? E.g. 'Avoid dirtying the cacheline if the folio is
already marked as dirty.'
> >   bool noop_dirty_folio(struct address_space *mapping, struct folio *folio)
> >   {
> > -	if (!folio_test_dirty(folio))
> > -		return !folio_test_set_dirty(folio);
> > -	return false;
> > +	return !folio_test_set_dirty(folio);
> >   }
Thanks
Zhiguo