Re: [syzbot] [ntfs3?] possible deadlock in ntfs_fallocate

From: syzbot
Date: Tue Sep 10 2024 - 22:39:34 EST

Next message: liuderong: "[PATCH v1 0/2] f2fs: modify the calculation method of mtime"
Previous message: Damon Ding: "[PATCH v3 0/2]"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

syzbot has found a reproducer for the following issue on:

HEAD commit: 8d8d276ba2fb Merge tag 'trace-v6.11-rc6' of git://git.kern..
git tree: upstream
console+strace: https://syzkaller.appspot.com/x/log.txt?x=10a5e807980000
kernel config: https://syzkaller.appspot.com/x/.config?x=1c9e296880039df9
dashboard link: https://syzkaller.appspot.com/bug?extid=adacb2b0c896bc427962
compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40
syz repro: https://syzkaller.appspot.com/x/repro.syz?x=13e9fbc7980000
C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1573a100580000

Downloadable assets:
disk image: https://storage.googleapis.com/syzbot-assets/29807f1973f6/disk-8d8d276b.raw.xz
vmlinux: https://storage.googleapis.com/syzbot-assets/172d57aa7f61/vmlinux-8d8d276b.xz
kernel image: https://storage.googleapis.com/syzbot-assets/021cabf6f499/bzImage-8d8d276b.xz
mounted in repro #1: https://storage.googleapis.com/syzbot-assets/3ada4caf0079/mount_0.gz
mounted in repro #2: https://storage.googleapis.com/syzbot-assets/7777f8d9c410/mount_7.gz

IMPORTANT: if you fix the issue, please add the following tag to the commit:
Reported-by: syzbot+adacb2b0c896bc427962@xxxxxxxxxxxxxxxxxxxxxxxxx

======================================================
WARNING: possible circular locking dependency detected
6.11.0-rc7-syzkaller-00020-g8d8d276ba2fb #0 Not tainted
------------------------------------------------------
syz-executor399/5227 is trying to acquire lock:
ffff8880758351c8 (&ni->ni_lock/4){+.+.}-{3:3}, at: ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline]
ffff8880758351c8 (&ni->ni_lock/4){+.+.}-{3:3}, at: ntfs_fallocate+0x5ca/0x1280 fs/ntfs3/file.c:564

but task is already holding lock:
ffff888075835600 (mapping.invalidate_lock#3){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:845 [inline]
ffff888075835600 (mapping.invalidate_lock#3){++++}-{3:3}, at: ntfs_fallocate+0x3c7/0x1280 fs/ntfs3/file.c:549

which lock already depends on the new lock.

the existing dependency chain (in reverse order) is:

-> #3 (mapping.invalidate_lock#3){++++}-{3:3}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
down_read+0xb1/0xa40 kernel/locking/rwsem.c:1526
filemap_invalidate_lock_shared include/linux/fs.h:855 [inline]
filemap_fault+0x658/0x1760 mm/filemap.c:3302
__do_fault+0x135/0x460 mm/memory.c:4655
do_shared_fault mm/memory.c:5121 [inline]
do_fault mm/memory.c:5195 [inline]
do_pte_missing mm/memory.c:3947 [inline]
handle_pte_fault+0x1176/0x6fc0 mm/memory.c:5521
__handle_mm_fault mm/memory.c:5664 [inline]
handle_mm_fault+0x1056/0x1ad0 mm/memory.c:5832
do_user_addr_fault arch/x86/mm/fault.c:1338 [inline]
handle_page_fault arch/x86/mm/fault.c:1481 [inline]
exc_page_fault+0x459/0x8c0 arch/x86/mm/fault.c:1539
asm_exc_page_fault+0x26/0x30 arch/x86/include/asm/idtentry.h:623

-> #2 (&vma->vm_lock->lock){++++}-{3:3}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
down_write+0x99/0x220 kernel/locking/rwsem.c:1579
vma_start_write include/linux/mm.h:747 [inline]
vma_link+0x270/0x4f0 mm/mmap.c:457
insert_vm_struct+0x2f7/0x410 mm/mmap.c:3484
__bprm_mm_init fs/exec.c:291 [inline]
bprm_mm_init fs/exec.c:395 [inline]
alloc_bprm+0x81f/0xda0 fs/exec.c:1623
kernel_execve+0x99/0xa50 fs/exec.c:2052
try_to_run_init_process init/main.c:1395 [inline]
kernel_init+0xed/0x2b0 init/main.c:1523
ret_from_fork+0x4b/0x80 arch/x86/kernel/process.c:147
ret_from_fork_asm+0x1a/0x30 arch/x86/entry/entry_64.S:244

-> #1 (&mm->mmap_lock){++++}-{3:3}:
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
__might_fault+0xc6/0x120 mm/memory.c:6387
_inline_copy_to_user include/linux/uaccess.h:176 [inline]
_copy_to_user+0x2a/0xb0 lib/usercopy.c:26
copy_to_user include/linux/uaccess.h:209 [inline]
fiemap_fill_next_extent+0x235/0x410 fs/ioctl.c:145
ni_fiemap+0x4f5/0x1910 fs/ntfs3/frecord.c:1993
ntfs_fiemap+0x132/0x180 fs/ntfs3/file.c:1279
ioctl_fiemap fs/ioctl.c:220 [inline]
do_vfs_ioctl+0x1c07/0x2e50 fs/ioctl.c:841
__do_sys_ioctl fs/ioctl.c:905 [inline]
__se_sys_ioctl+0x81/0x170 fs/ioctl.c:893
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

-> #0 (&ni->ni_lock/4){+.+.}-{3:3}:
check_prev_add kernel/locking/lockdep.c:3133 [inline]
check_prevs_add kernel/locking/lockdep.c:3252 [inline]
validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3868
__lock_acquire+0x137a/0x2040 kernel/locking/lockdep.c:5142
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
__mutex_lock_common kernel/locking/mutex.c:608 [inline]
__mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline]
ntfs_fallocate+0x5ca/0x1280 fs/ntfs3/file.c:564
vfs_fallocate+0x553/0x6c0 fs/open.c:334
do_vfs_ioctl+0x2592/0x2e50 fs/ioctl.c:886
__do_sys_ioctl fs/ioctl.c:905 [inline]
__se_sys_ioctl+0x81/0x170 fs/ioctl.c:893
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f

other info that might help us debug this:

Chain exists of:
&ni->ni_lock/4 --> &vma->vm_lock->lock --> mapping.invalidate_lock#3

Possible unsafe locking scenario:

CPU0 CPU1
---- ----
lock(mapping.invalidate_lock#3);
lock(&vma->vm_lock->lock);
lock(mapping.invalidate_lock#3);
lock(&ni->ni_lock/4);

*** DEADLOCK ***

3 locks held by syz-executor399/5227:
#0: ffff888031898420 (sb_writers#9){.+.+}-{0:0}, at: file_start_write include/linux/fs.h:2882 [inline]
#0: ffff888031898420 (sb_writers#9){.+.+}-{0:0}, at: vfs_fallocate+0x4ea/0x6c0 fs/open.c:333
#1: ffff888075835460 (&sb->s_type->i_mutex_key#14){+.+.}-{3:3}, at: inode_lock include/linux/fs.h:800 [inline]
#1: ffff888075835460 (&sb->s_type->i_mutex_key#14){+.+.}-{3:3}, at: ntfs_fallocate+0x2e0/0x1280 fs/ntfs3/file.c:535
#2: ffff888075835600 (mapping.invalidate_lock#3){++++}-{3:3}, at: filemap_invalidate_lock include/linux/fs.h:845 [inline]
#2: ffff888075835600 (mapping.invalidate_lock#3){++++}-{3:3}, at: ntfs_fallocate+0x3c7/0x1280 fs/ntfs3/file.c:549

stack backtrace:
CPU: 0 UID: 0 PID: 5227 Comm: syz-executor399 Not tainted 6.11.0-rc7-syzkaller-00020-g8d8d276ba2fb #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 08/06/2024
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:93 [inline]
dump_stack_lvl+0x241/0x360 lib/dump_stack.c:119
check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2186
check_prev_add kernel/locking/lockdep.c:3133 [inline]
check_prevs_add kernel/locking/lockdep.c:3252 [inline]
validate_chain+0x18e0/0x5900 kernel/locking/lockdep.c:3868
__lock_acquire+0x137a/0x2040 kernel/locking/lockdep.c:5142
lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5759
__mutex_lock_common kernel/locking/mutex.c:608 [inline]
__mutex_lock+0x136/0xd70 kernel/locking/mutex.c:752
ni_lock fs/ntfs3/ntfs_fs.h:1110 [inline]
ntfs_fallocate+0x5ca/0x1280 fs/ntfs3/file.c:564
vfs_fallocate+0x553/0x6c0 fs/open.c:334
do_vfs_ioctl+0x2592/0x2e50 fs/ioctl.c:886
__do_sys_ioctl fs/ioctl.c:905 [inline]
__se_sys_ioctl+0x81/0x170 fs/ioctl.c:893
do_syscall_x64 arch/x86/entry/common.c:52 [inline]
do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83
entry_SYSCALL_64_after_hwframe+0x77/0x7f
RIP: 0033:0x7f7cf99c7c99
Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48
RSP: 002b:00007ffc8fd1f9c8 EFLAGS: 00000246 ORIG_RAX: 0000000000000010
RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007f7cf99c7c99
RDX: 0000000020000000 RSI: 0000000040305829 RDI: 0000000000000006
RBP: 0000000000000000 R08: 0000000000000000 R09: 00007ffc8fd1fa00
R10: 00007ffc8fd1f9d0 R11: 0000000000000246 R12: 00007ffc8fd1fa00
R13: 00007ffc8fd1fc88 R14: 431bde82d7b634db R15: 00007f7cf9a1003b
</TASK>

---
If you want syzbot to run the reproducer, reply with:
#syz test: git://repo/address.git branch-or-commit-hash
If you attach or paste a git patch, syzbot will apply it before testing.

Next message: liuderong: "[PATCH v1 0/2] f2fs: modify the calculation method of mtime"
Previous message: Damon Ding: "[PATCH v3 0/2]"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]