Re: [PATCH 07/21] KVM: TDX: Add load_mmu_pgd method for TDX

From: Edgecombe, Rick P
Date: Tue Sep 10 2024 - 22:50:04 EST


On Wed, 2024-09-11 at 10:48 +0800, Chao Gao wrote:
> > index 2ef95c84ee5b..8f43977ef4c6 100644
> > --- a/arch/x86/kvm/vmx/tdx.c
> > +++ b/arch/x86/kvm/vmx/tdx.c
> > @@ -428,6 +428,11 @@ void tdx_vcpu_reset(struct kvm_vcpu *vcpu, bool
> > init_event)
> >          */
> > }
> >
> > +void tdx_load_mmu_pgd(struct kvm_vcpu *vcpu, hpa_t root_hpa, int pgd_level)
> > +{
>
> pgd_level isn't used. So, I think we can either drop it or assert that it
> matches
> the secure EPT level.

Oh, yea. Good point.