Re: [PATCH v5 1/3] tty: serial: samsung: Use bit manipulation macros for APPLE_S5L_*

From: Andi Shyti
Date: Wed Sep 11 2024 - 02:58:02 EST


Hi Nick,

On Wed, Sep 11, 2024 at 01:02:11PM GMT, Nick Chan wrote:
> New entries using BIT() will be added soon, so change the existing ones to
> use bit manipulation macros including BIT() and GENMASK() for
> consistency.
>
> Suggested-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Tested-by: Janne Grunau <j@xxxxxxxxxx>
> Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
> Signed-off-by: Nick Chan <towinchenmi@xxxxxxxxx>

Thanks for the cleanup!

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

Andi