Re: [PATCH v5 2/3] tty: serial: samsung: Fix A7-A11 serial earlycon SError

[Andi Shyti]

Hi Nick,

On Wed, Sep 11, 2024 at 01:02:12PM GMT, Nick Chan wrote:
> Apple's earlier SoCs, like A7-A11, requires 32-bit writes for the serial
> port. Otherwise, a SError happens when writing to UTXH (+0x20). This only
> manifested in earlycon as reg-io-width in the device tree is consulted
> for normal serial writes.
> 
> Change the iotype of the port to UPIO_MEM32, to allow the serial port to
> function on A7-A11 SoCs. This change does not appear to affect Apple M1 and
> above.
> 
> Reviewed-by: Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> Reviewed-by: Neal Gompa <neal@xxxxxxxxx>
> Tested-by: Janne Grunau <j@xxxxxxxxxx>
> Signed-off-by: Nick Chan <towinchenmi@xxxxxxxxx>

Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxx>

Andi