Re: [PATCH v2 09/15] timers: Add a warning to usleep_range_state() for wrong order of arguments

[Anna-Maria Behnsen]

Joe Perches <joe@xxxxxxxxxxx> writes:

> On Wed, 2024-09-11 at 07:13 +0200, Anna-Maria Behnsen wrote:
>> There is a warning in checkpatch script that triggers, when min and max
>> arguments of usleep_range_state() are in reverse order. This check does
>> only cover callsites which uses constants. Move this check into the code as
>> a WARN_ON_ONCE() to also cover callsites not using constants and get rid of
>> it in checkpatch.
>
> I don't disagree that a runtime test is useful
> and relatively cost free.
>
> But checkpatch is for patches.
>
> There's no reason as far as I can tell to remove
> this source code test.
>
> Why make the test runtime only?
>

Sure, we can keep the test in checkpatch as well and I will only add the
runtime check. Then I would change the link to the documentation in
checkpatch into a link to the updated function description. Before I do
any update there, I want to wait for your answer to the other patch of
the queue.

Thanks,

	Anna-Maria