Re: [PATCH v1 2/7] vhost: Add kthread support in function vhost_worker_queue()

From: kernel test robot
Date: Wed Sep 11 2024 - 07:15:06 EST


Hi Cindy,

kernel test robot noticed the following build errors:

[auto build test ERROR on mst-vhost/linux-next]
[also build test ERROR on linus/master v6.11-rc7 next-20240910]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Cindy-Lu/vhost-Add-a-new-module_param-for-enable-kthread/20240909-093852
base: https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git linux-next
patch link: https://lore.kernel.org/r/20240909013531.1243525-3-lulu%40redhat.com
patch subject: [PATCH v1 2/7] vhost: Add kthread support in function vhost_worker_queue()
config: arc-randconfig-001-20240911 (https://download.01.org/0day-ci/archive/20240911/202409111842.o3eEppU6-lkp@xxxxxxxxx/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240911/202409111842.o3eEppU6-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409111842.o3eEppU6-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

drivers/vhost/vhost.c: In function 'vhost_worker_queue':
>> drivers/vhost/vhost.c:272:13: error: 'use_kthread' undeclared (first use in this function)
272 | if (use_kthread) {
| ^~~~~~~~~~~
drivers/vhost/vhost.c:272:13: note: each undeclared identifier is reported only once for each function it appears in


vim +/use_kthread +272 drivers/vhost/vhost.c

268
269 static void vhost_worker_queue(struct vhost_worker *worker,
270 struct vhost_work *work)
271 {
> 272 if (use_kthread) {
273 vhost_work_queue_kthread(worker, work);
274 } else {
275 vhost_worker_queue_task(worker, work);
276 }
277 }
278 bool vhost_vq_work_queue(struct vhost_virtqueue *vq, struct vhost_work *work)
279 {
280 struct vhost_worker *worker;
281 bool queued = false;
282
283 rcu_read_lock();
284 worker = rcu_dereference(vq->worker);
285 if (worker) {
286 queued = true;
287 vhost_worker_queue(worker, work);
288 }
289 rcu_read_unlock();
290
291 return queued;
292 }
293 EXPORT_SYMBOL_GPL(vhost_vq_work_queue);
294

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki