Re: [PATCH v2 6/8] arm64: dts: mediatek: mt8188: Add SPMI support for PMIC control

[AngeloGioacchino Del Regno]

Il 11/09/24 12:51, Fei Shao ha scritto:
> Add SPMI node for PMIC control on MT8188 SoC.
>
> Signed-off-by: Fei Shao <fshao@xxxxxxxxxxxx>
> ---
>
> (no changes since v1)
>
>   arch/arm64/boot/dts/mediatek/mt8188.dtsi | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8188.dtsi b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> index 61530f8c5599..32e5b7108f6a 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8188.dtsi
> @@ -1306,6 +1306,18 @@ pwrap: pwrap@10024000 {
>   			clock-names = "spi", "wrap";
>   		};
>   
> +		spmi: spmi@10027000 {
> +			compatible = "mediatek,mt8188-spmi", "mediatek,mt8195-spmi";
> +			reg = <0 0x10027000 0 0x000e00>, <0 0x10029000 0 0x000100>;

Please drop leading zeroes on iospace sizes 0xe00 and 0x100, after which:

Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>