Re: [PATCH] kbuild: Support separating source and output of the external module

[Masahiro Yamada]

On Wed, Sep 11, 2024 at 8:20 PM Jing Leng <3090101217@xxxxxxxxxx> wrote:
>
> Revert commit "9a0ebe5011f4", originally when compiling external modules,
> the compiled output can be separated from the source code with the
> following command:
>     make -C <kernel_src> O=<kernel_out> src=<module_src> M=<module_out>
> It is used to https://github.com/lengjingzju/cbuild-ng (inc.mod.mk).
>
> But "src" is an internal variable, so this patch adds a variable "S"
> which is specifically used to change the default value of "src".
>
> Fixes: 9a0ebe5011f4 ("kbuild: use $(obj)/ instead of $(src)/ for common pattern rules")
> Signed-off-by: Jing Leng <3090101217@xxxxxxxxxx>


NACK.

Always sign, every time I receive a hack like this over and  over again.


-- 
Best Regards
Masahiro Yamada