Re: [PATCH 8/9] accel/rocket: Add job submission IOCTL

From: Markus Elfring
Date: Wed Sep 11 2024 - 08:04:20 EST

Next message: Frederic Weisbecker: "[PATCH] kthread: Unpark only parked kthreads (was Re: [syzbot] [wireguard?] WARNING in kthread_unpark (2))"
Previous message: Qianqiang Liu: "Re: [PATCH] ASoC: mt8365: Fix using uninitialized value "i2s_data" issue"
In reply to: Markus Elfring: "Re: [PATCH 8/9] accel/rocket: Add job submission IOCTL"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

…
> +++ b/drivers/accel/rocket/rocket_job.h
> @@ -0,0 +1,49 @@
…
> +#ifndef __ROCKET_JOB_H__
> +#define __ROCKET_JOB_H__
…

I suggest to omit leading underscores from such identifiers.
https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier

Regards,
Markus

Next message: Frederic Weisbecker: "[PATCH] kthread: Unpark only parked kthreads (was Re: [syzbot] [wireguard?] WARNING in kthread_unpark (2))"
Previous message: Qianqiang Liu: "Re: [PATCH] ASoC: mt8365: Fix using uninitialized value "i2s_data" issue"
In reply to: Markus Elfring: "Re: [PATCH 8/9] accel/rocket: Add job submission IOCTL"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]