Re: [PATCH v3 2/2] mm: Allocate THP on hugezeropage wp-fault

[David Hildenbrand]

> > >    }
> > >      static vm_fault_t __do_huge_pmd_anonymous_page(struct vm_fault *vmf)
> > > @@ -1576,6 +1580,41 @@ void huge_pmd_set_accessed(struct vm_fault *vmf)
> > >        spin_unlock(vmf->ptl);
> > >    }
> > >    +static vm_fault_t do_huge_zero_wp_pmd(struct vm_fault *vmf,
> > > unsigned long haddr)
> >
> > Is there a need to pass in "haddr" if we have the vmf?
>
> Was passing it because it was getting used many times. But nowhere do vmf
> and haddr get both passed in the codebase, so I'll drop it for
> cleanliness and
> consistency.

Yes, the masking is very cheap.

--
Cheers,

David / dhildenb