Re: [PATCH v3 0/2] Add I2C driver for Bosch BMI270 IMU
From: Alex Lanzano
Date: Wed Sep 11 2024 - 08:38:43 EST
On Wed, Sep 11, 2024 at 12:22:54AM GMT, Vasileios Amoiridis wrote:
> Hi Alex!
>
> I recently received a review for the code for the BMP280 sensors, and I think
> it applies well to you as well. Since you are using the sleeping functions in
> your code, maybe a comment on top that explains why this value or where you
> found it in the datasheet would be helpful.
>
> Specifically for the Bosch Sensors, because Bosch's datasheets have either
> hidden or no information at all, and you need to search for stuff in the
> respective C sensor API in the Bosch GitHub.
Thanks for the review! I'll be sure to comment the sleeping functions.
Best regards,
Alex