Re: [PATCH] dt-bindings: PCI: qcom: Allow 'vddpe-3v3-supply' again
From: Johan Hovold
Date: Wed Sep 11 2024 - 09:59:08 EST
On Wed, Sep 11, 2024 at 08:51:06AM -0500, Bjorn Helgaas wrote:
> On Thu, Aug 22, 2024 at 11:07:33AM +0200, Johan Hovold wrote:
> > On Tue, Jul 23, 2024 at 05:13:28PM +0200, Johan Hovold wrote:
> > > Commit 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to
> > > dedicated schema") incorrectly removed 'vddpe-3v3-supply' from the
> > > bindings, which results in DT checker warnings like:
> > >
> > > arch/arm64/boot/dts/qcom/msm8996-sony-xperia-tone-dora.dtb: pcie@600000: Unevaluated properties are not allowed ('vddpe-3v3-supply' was unexpected)
> > > from schema $id: http://devicetree.org/schemas/pci/qcom,pcie.yaml#
> > >
> > > Note that this property has been part of the Qualcomm PCIe bindings
> > > since 2018 and would need to be deprecated rather than simply removed if
> > > there is a desire to replace it with 'vpcie3v3' which is used for some
> > > non-Qualcomm controllers.
> > >
> > > Fixes: 756485bfbb85 ("dt-bindings: PCI: qcom,pcie-sc7280: Move SC7280 to dedicated schema")
> > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
> >
> > Can someone pick this one up for 6.11?
>
> I applied this to pci/dt-bindings for v6.12.
>
> v6.11 is possible but we'd need a bit of a story to justify it.
> 756485bfbb85 appeared in v6.9, and the commit log says it fixes a DT
> checker warning, which don't make it sound like this is urgent. Is
> there more to it that would make this v6.11 material?
No, merging for 6.12 is fine (e.g. this late in the cycle). Thanks.
Johan