Re: [PATCH v2] selftests: vDSO: don't include generated headers for chacha test

From: Mark Brown
Date: Wed Sep 11 2024 - 10:12:45 EST


On Wed, Sep 11, 2024 at 03:36:32PM +0200, Jason A. Donenfeld wrote:

> It's not correct to use $(top_srcdir) for generated header files, for
> builds that are done out of tree via O=, and $(objtree) isn't valid in
> the selftests context. Instead, just obviate the need for these
> generated header files by defining empty stubs in tools/include, which
> is the same thing that's done for rwlock.h.

...

> I'll replace the broken commit with this one. I've verified the
> kselftests are fine now, particularly for kvm.

Did you also check perf? For arm64 it uses the sysregs values though I
don't off hand know if that includes any of the generated values. I
would expect that KVM will start breaking for arm64 at some point even
if it works for now, there was a desire to replace use of magic numbers
for registers in the tests with defines.

Attachment: signature.asc
Description: PGP signature