Re: [PATCH] driver core: Don't try to create links if they are not needed

From: Greg Kroah-Hartman
Date: Wed Sep 11 2024 - 10:32:23 EST


On Tue, Sep 10, 2024 at 02:00:19PM +0100, Jon Hunter wrote:
> The following error messages are observed on boot with the Tegra234
> Jetson AGX Orin board ...
>
> tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180)
> with 1-0008
> tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180)
> with 1-0008
> tegra-xusb-padctl 3520000.padctl: Failed to create device link (0x180)
> with 1-0008
>
> In the above case, device_link_add() intentionally returns NULL because
> these are SYNC_STATE_ONLY links and the device is already probed.
> Therefore, the above messages are not actually errors. Fix this by
> replicating the test from device_link_add() in the function
> fw_devlink_create_devlink() and don't call device_link_add() if there
> are no links to create.
>
> Signed-off-by: Jon Hunter <jonathanh@xxxxxxxxxx>

What commit id does this fix?

thanks,

greg k-h