Re: [PATCH v3 1/3] dt-bindings: display/xlnx/zynqmp-dpsub: Add audio DMAs

From: Rob Herring (Arm)
Date: Wed Sep 11 2024 - 11:19:33 EST



On Tue, 10 Sep 2024 14:19:19 +0300, Tomi Valkeinen wrote:
> The DP subsystem for ZynqMP supports audio via two channels, and the DP
> DMA has dma-engines for those channels. For some reason the DT binding
> has not specified those channels, even if the picture included in
> xlnx,zynqmp-dpsub.yaml shows "2 x aud" DMAs.
>
> This hasn't caused any issues as the drivers have not supported audio,
> and has thus gone unnoticed.
>
> To make it possible to add the audio support to the driver, add the two
> audio DMAs to the binding. While strictly speaking this is an ABI break,
> there should be no regressions caused by this as we're adding new
> entries at the end of the dmas list, and, after the audio support has
> been added in "arm64: dts: zynqmp: Add DMA for DP audio", the driver
> will treat the audio DMAs as optional to also support the old bindings.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/display/xlnx/xlnx,zynqmp-dpsub.yaml | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>

Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>