Re: [PATCH] tools: drop nonsensical -O6
From: Arnaldo Carvalho de Melo
Date: Wed Sep 11 2024 - 11:52:13 EST
On Mon, Sep 09, 2024 at 03:16:01PM -0700, Namhyung Kim wrote:
> Hello,
>
> On Sun, Sep 08, 2024 at 07:46:41PM +0100, Sam James wrote:
> > -O6 is very much not-a-thing. Really, this should've been dropped
> > entirely in 49b3cd306e60b9d889c775cb2ebb709f80dd8ae9 instead of just
> > passing it for not-Clang.
> >
> > Just collapse it down to -O3, instead of "-O6 unless Clang, in which case
> > -O3".
> >
> > GCC interprets > -O3 as -O3. It doesn't even interpret > -O3 as -Ofast,
> > which is a good thing, given -Ofast has specific (non-)requirements for
> > code built using it. So, this does nothing except look a bit daft.
> >
> > Remove the silliness and also save a few lines in the Makefiles accordingly.
> >
> > Signed-off-by: Sam James <sam@xxxxxxxxxx>
>
> Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>
Thanks, applied to perf-tools-next,
- Arnaldo