Re: [PATCH v1 11/12] i2c: isch: Prefer to use octal permission

From: Andy Shevchenko
Date: Wed Sep 11 2024 - 12:07:18 EST


On Wed, Sep 11, 2024 at 05:53:44PM +0200, Jesper Juhl wrote:
> Personally I find this to be *less* readable, but maybe that's just me.

It's just you :-)

checkpatch should complain nowadays about non-octal permissions.
It is documented here Documentation/dev-tools/checkpatch.rst.
IIRC it's added after Linus' rant on them.

But nonetheless thanks for the review!

> On Wed, 11 Sept 2024 at 17:51, Andy Shevchenko
> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> >
> > Octal permissions are preferred over the symbolics ones
> > for readbility. This ceases warning message pointed by checkpatch.


--
With Best Regards,
Andy Shevchenko