Re: [PATCH 8/8] addon_boards: mikrobus: Add GPS3 Click

[Greg Kroah-Hartman]

On Wed, Sep 11, 2024 at 09:26:06PM +0530, Ayush Singh wrote:
> On 9/11/24 20:28, Greg Kroah-Hartman wrote:
> 
> > On Wed, Sep 11, 2024 at 07:57:25PM +0530, Ayush Singh wrote:
> > > - GPS3 Click is a UART MikroBUS addon Board
> > > 
> > > Link: https://www.mikroe.com/gps-3-click
> > > 
> > > Signed-off-by: Ayush Singh <ayush@xxxxxxxxxxxxxxx>
> > > ---
> > >   addon_boards/mikrobus/Makefile         |  1 +
> > >   addon_boards/mikrobus/mikroe-1714.dtso | 28 ++++++++++++++++++++++++++++
> > Odd top-level directory for the kernel, are you sure this is correct?
> > 
> > thanks,
> > 
> > greg k-h
> > 
> Well, it is kinda a temporary location, since well, I could not find a good
> place for board overlays but a top-level location seems better than putting
> them in any arch specific location. I am open to moving them to a more
> suitable location if we have one.

top-level location is not ok for something so tiny and "special".  Just
put it where all other dtso files go.

thanks,

greg k-h