Re: [PATCH 1/2] dt-bindings: pinctrl: document the QCS615 Top Level Mode Multiplexer

[Lijuan Gao]

在 9/11/2024 11:18 PM, Rob Herring 写道:
> On Tue, Sep 10, 2024 at 06:26:14PM +0800, Lijuan Gao wrote:
> > Document the Top Level Mode Multiplexer on the QCS615 Platform.
> > It concisely explains the pin multiplexing and configuration in
> > the device tree, and includes simple examples of typical device
> > tree snippets, making it easier for designers to configure and
> > manage chip pins.
> >
> > Signed-off-by: Lijuan Gao <quic_lijuang@xxxxxxxxxxx>
> > ---
> >   .../bindings/pinctrl/qcom,qcs615-tlmm.yaml         | 123 +++++++++++++++++++++
> >   1 file changed, 123 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml
> > new file mode 100644
> > index 000000000000..2bfb0a453880
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/pinctrl/qcom,qcs615-tlmm.yaml
> > @@ -0,0 +1,123 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/pinctrl/qcom,qcs615-tlmm.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm Technologies, Inc. QCS615 TLMM block
> > +
> > +maintainers:
> > +  - Lijuan Gao <quic_lijuang@xxxxxxxxxxx>
> > +
> > +description:
> > +  Top Level Mode Multiplexer pin controller in Qualcomm QCS615 SoC.
> > +
> > +allOf:
> > +  - $ref: /schemas/pinctrl/qcom,tlmm-common.yaml#
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,qcs615-tlmm
> > +
> > +  reg:
> > +    maxItems: 3
> > +
> > +  reg-names:
> > +    items:
> > +      - const: east
> > +      - const: west
> > +      - const: south
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  gpio-reserved-ranges:
> > +    minItems: 1
> > +    maxItems: 62
> > +
> > +  gpio-line-names:
> > +    maxItems: 123
> > +
> > +patternProperties:
> > +  "-state$":
> > +    oneOf:
> > +      - $ref: "#/$defs/qcom-qcs615-tlmm-state"
> > +      - patternProperties:
>
> Needs 'type: object' before patternProperties.
> > Otherwise,
>
> Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
Well noted.


--
Thx and BRs
Lijuan Gao