Re: [PATCH v3 3/3] arm64: dts: rockchip: add dts for Ariaboard Photonicat RK3568

[Chukun Pan]

Hi Junhao,

> ...
> --- /dev/null
> +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
> ...

> +	rfkill-modem {
> +		compatible = "rfkill-gpio";
> +		label = "M.2 USB Modem";
> +		radio-type = "wwan";
> +		reset-gpios = <&gpio0 RK_PB0 GPIO_ACTIVE_LOW>;
> +		shutdown-gpios = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>;
> +	};

gpio0 RK_PB0 conflicts with xin32k, please add:

&xin32k {
	pinctrl-names = "default";
	pinctrl-0 = <&clk32k_out1>;
};

> +	vccin_5v: regulator-5v0-vcc-in {
> +	vcc_sysin: regulator-5v0-vcc-sysin {
> +	vcc_syson: regulator-5v0-vcc-syson {
> +	vcc5v0_usb30_otg0: regulator-5v0-vcc-usb-host {

obviously (

-- 
2.25.1