Re: linux-next: build failure after merge of the loongarch tree

From: lixianglai
Date: Wed Sep 11 2024 - 23:33:43 EST


Hi Stephen Rothwell:

Thank you very much for your feedback.
I think the following modification can solve the compilation problem of ppc64.
I have verified it on the x86 cross environment,
and I will incorporate the modification into the next version of patch.

 #define kvm_trace_symbol_iocsr \
-       ({ KVM_TRACE_IOCSR_READ_UNSATISFIED, "unsatisfied-read" }, \
+       { KVM_TRACE_IOCSR_READ_UNSATISFIED, "unsatisfied-read" }, \
        { KVM_TRACE_IOCSR_READ, "read" }, \
-       { KVM_TRACE_IOCSR_WRITE, "write" })
+       { KVM_TRACE_IOCSR_WRITE, "write" }

Thanks,
Xianglai.

Hi all,

After merging the loongarch tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from include/trace/define_trace.h:102,
from include/trace/events/kvm.h:530,
from arch/powerpc/kvm/../../../virt/kvm/kvm_main.c:65:
include/trace/events/kvm.h: In function 'trace_raw_output_kvm_iocsr':
include/trace/events/kvm.h:244:44: error: left-hand operand of comma expression has no effect [-Werror=unused-value]
244 | ({ KVM_TRACE_IOCSR_READ_UNSATISFIED, "unsatisfied-read" }, \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/events/kvm.h:270:51: note: in expansion of macro 'kvm_trace_symbol_iocsr'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~~~~~~~
include/trace/events/kvm.h:244:65: error: expected ';' before '}' token
244 | ({ KVM_TRACE_IOCSR_READ_UNSATISFIED, "unsatisfied-read" }, \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/events/kvm.h:270:51: note: in expansion of macro 'kvm_trace_symbol_iocsr'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~~~~~~~
include/trace/events/kvm.h:244:66: error: expected ')' before ',' token
244 | ({ KVM_TRACE_IOCSR_READ_UNSATISFIED, "unsatisfied-read" }, \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/events/kvm.h:270:51: note: in expansion of macro 'kvm_trace_symbol_iocsr'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~~~~~~~
include/trace/events/kvm.h:244:9: error: initialization of 'long unsigned int' from 'char *' makes integer from pointer without a cast [-Wint-conversion]
244 | ({ KVM_TRACE_IOCSR_READ_UNSATISFIED, "unsatisfied-read" }, \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/events/kvm.h:270:51: note: in expansion of macro 'kvm_trace_symbol_iocsr'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~~~~~~~
include/trace/events/kvm.h:244:9: note: (near initialization for 'symbols[0].mask')
244 | ({ KVM_TRACE_IOCSR_READ_UNSATISFIED, "unsatisfied-read" }, \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/events/kvm.h:270:51: note: in expansion of macro 'kvm_trace_symbol_iocsr'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~~~~~~~
include/trace/events/kvm.h:244:9: error: initializer element is not constant
244 | ({ KVM_TRACE_IOCSR_READ_UNSATISFIED, "unsatisfied-read" }, \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/events/kvm.h:270:51: note: in expansion of macro 'kvm_trace_symbol_iocsr'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~~~~~~~
include/trace/events/kvm.h:244:9: note: (near initialization for 'symbols[0].mask')
244 | ({ KVM_TRACE_IOCSR_READ_UNSATISFIED, "unsatisfied-read" }, \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/events/kvm.h:270:51: note: in expansion of macro 'kvm_trace_symbol_iocsr'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~~~~~~~
include/trace/stages/stage3_trace_output.h:77:37: error: braces around scalar initializer [-Werror]
77 | static const struct trace_print_flags symbols[] = \
| ^~~~~~~~~~~~~~~~~
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/stages/stage3_trace_output.h:77:37: note: (near initialization for 'symbols[0].name')
77 | static const struct trace_print_flags symbols[] = \
| ^~~~~~~~~~~~~~~~~
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/stages/stage3_trace_output.h:78:43: error: initialization of 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
78 | { symbol_array, { -1, NULL }}; \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/stages/stage3_trace_output.h:78:43: note: (near initialization for 'symbols[0].name')
78 | { symbol_array, { -1, NULL }}; \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/linux/stddef.h:8:14: error: excess elements in scalar initializer [-Werror]
8 | #define NULL ((void *)0)
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/stages/stage3_trace_output.h:78:47: note: in expansion of macro 'NULL'
78 | { symbol_array, { -1, NULL }}; \
| ^~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/linux/stddef.h:8:14: note: (near initialization for 'symbols[0].name')
8 | #define NULL ((void *)0)
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/stages/stage3_trace_output.h:78:47: note: in expansion of macro 'NULL'
78 | { symbol_array, { -1, NULL }}; \
| ^~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
include/trace/stages/stage3_trace_output.h:78:25: error: missing braces around initializer [-Werror=missing-braces]
78 | { symbol_array, { -1, NULL }}; \
| ^
include/trace/trace_events.h:203:34: note: in definition of macro 'DECLARE_EVENT_CLASS'
203 | trace_event_printf(iter, print); \
| ^~~~~
include/trace/trace_events.h:45:30: note: in expansion of macro 'PARAMS'
45 | PARAMS(print)); \
| ^~~~~~
include/trace/events/kvm.h:248:1: note: in expansion of macro 'TRACE_EVENT'
248 | TRACE_EVENT(kvm_iocsr,
| ^~~~~~~~~~~
include/trace/events/kvm.h:269:9: note: in expansion of macro 'TP_printk'
269 | TP_printk("iocsr %s len %u gpa 0x%llx val 0x%llx",
| ^~~~~~~~~
include/trace/events/kvm.h:270:19: note: in expansion of macro '__print_symbolic'
270 | __print_symbolic(__entry->type, kvm_trace_symbol_iocsr),
| ^~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Caused by commit

a7e93cf65d8a ("LoongArch: KVM: Add iocsr and mmio bus simulation in kernel")

I have used the loongarch tree from next-20240911 for today.