Re: [PATCH net-next V2 5/5] net: lan743x: Add Support for 2.5G SFP with 2500Base-X Interface

[Raju Lakkaraju]

Hi Andrew,

The 09/11/2024 19:31, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> > @@ -3359,6 +3362,7 @@ static int lan743x_phylink_create(struct lan743x_adapter *adapter)
> >       lan743x_phy_interface_select(adapter);
> >
> >       switch (adapter->phy_interface) {
> > +     case PHY_INTERFACE_MODE_2500BASEX:
> >       case PHY_INTERFACE_MODE_SGMII:
> >               __set_bit(PHY_INTERFACE_MODE_SGMII,
> >                         adapter->phylink_config.supported_interfaces);
> 
> I _think_ you also need to set the PHY_INTERFACE_MODE_2500BASEX bit in
> phylink_config.supported_interfaces if you actually support it.
> 
It's already add support. Here it's showing only diff changes

> Have you tested an SFP module capable of 2500BASEX?
> 
Yes. I test SFP module (FS's make 2.5G Cu SFP (SFP-2.5G-T))
it's working as expected.

>         Andrew

-- 
Thanks,                                                                         
Raju