Re: [PATCH v1 00/12] i2c: isch: Put the driver into shape

From: Andi Shyti
Date: Thu Sep 12 2024 - 03:33:52 EST


Hi Andy,

> Andy Shevchenko (12):
> i2c: isch: Add missed 'else'
> i2c: isch: Pass pointer to struct i2c_adapter down
> i2c: isch: Use string_choices API instead of ternary operator
> i2c: isch: Switch to memory mapped IO accessors
> i2c: isch: Use custom private data structure
> i2c: isch: switch i2c registration to devm functions
> i2c: isch: Utilize temporary variable to hold device pointer
> i2c: isch: Use read_poll_timeout()
> i2c: isch: Unify the name of the variable to hold an error code
> i2c: isch: Don't use "proxy" headers
> i2c: isch: Prefer to use octal permission
> i2c: isch: Convert to kernel-doc

very nice cleanup! Now this driver has a nice modern look.
Thanks!

I will leave this patch for some time to give it some more time
for review and then I will take it in.

Thanks,
Andi