Re: [PATCH 1/4] dt-bindings: rtc: add schema for NXP S32G2/S32G3 SoCs

From: Ciprian Marian Costea
Date: Thu Sep 12 2024 - 08:00:54 EST


On 9/12/2024 2:13 PM, Conor Dooley wrote:
On Thu, Sep 12, 2024 at 01:55:34PM +0300, Ciprian Marian Costea wrote:
On 9/11/2024 9:22 PM, Conor Dooley wrote:
On Wed, Sep 11, 2024 at 10:00:25AM +0300, Ciprian Costea wrote:
From: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx>

This patch adds the dt-bindings for NXP S32G2/S32G3 SoCs RTC driver.

+properties:
+ compatible:
+ const: nxp,s32g-rtc

Also, how come there are not specific compatibles for the two SoCs
supported here?

Hello Conor,

The RTC module is the same for S32G2 and S32G3 SoCs.
Therefore, I did not wanted to add two compatible strings ('nxp,s32g2-rtc'
and 'nxp,s32g3-rtc') when there is no actual difference which they could
target.

Are these different fusings of the same silicon, or are they distinctly
different SoCs that happen to share an IP block?


S32G2 and S32G3 are different SoCs that share the RTC IP block.

Furthermore, in the future I plan to refactor the common part from [1] and
[2] files into 's32g.dtsi'. Maybe then such common compatible strings would
make more sense.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/freescale/s32g2.dtsi

[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/freescale/s32g3.dtsi

Regards,
Ciprian