Re: [PATCH] dt-bindings: serial: rs485: Fix rs485-rts-delay property

[Greg Kroah-Hartman]

On Thu, Sep 12, 2024 at 02:05:28PM +0200, Michal Simek wrote:
> Code expects array only with 2 items which should be checked.
> But also item checking is not working as it should likely because of
> incorrect items description.
> 
> Fixes: d50f974c4f7f ("dt-bindings: serial: Convert rs485 bindings to json-schema")
> Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
> ---
> 
>  .../devicetree/bindings/serial/rs485.yaml     | 20 +++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/rs485.yaml b/Documentation/devicetree/bindings/serial/rs485.yaml
> index 9418fd66a8e9..fa9ad68ed24b 100644
> --- a/Documentation/devicetree/bindings/serial/rs485.yaml
> +++ b/Documentation/devicetree/bindings/serial/rs485.yaml
> @@ -17,17 +17,17 @@ properties:
>    rs485-rts-delay:
>      description: prop-encoded-array <a b>
>      $ref: /schemas/types.yaml#/definitions/uint32-array
> +    maxItems: 2
>      items:
> -      items:
> -        - description: Delay between rts signal and beginning of data sent in
> -            milliseconds. It corresponds to the delay before sending data.
> -          default: 0
> -          maximum: 100
> -        - description: Delay between end of data sent and rts signal in milliseconds.
> -            It corresponds to the delay after sending data and actual release
> -            of the line.
> -          default: 0
> -          maximum: 100
> +      - description: Delay between rts signal and beginning of data sent in
> +          milliseconds. It corresponds to the delay before sending data.
> +        default: 0
> +        maximum: 50
> +      - description: Delay between end of data sent and rts signal in milliseconds.
> +          It corresponds to the delay after sending data and actual release
> +          of the line.
> +        default: 0
> +        maximum: 100
>  
>    rs485-rts-active-high:
>      description: drive RTS high when sending (this is the default).
> -- 
> 2.43.0
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot