Re: [PATCH 01/13] media: i2c: imx214: Use subdev active state

From: Ricardo Ribalda Delgado
Date: Thu Sep 12 2024 - 09:43:46 EST

Next message: Ricardo Ribalda Delgado: "Re: [PATCH 02/13] media: i2c: imx214: Remove unneeded goto"
Previous message: Ricardo Ribalda Delgado: "Re: [PATCH 03/13] media: i2c: imx214: Simplify with dev_err_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi Andre

I don't have access to the hardware anymore, so I cannot test this...
but looking at the code I am not sure how it is working...

I would assume that after moving to the subdev active state, you need to remove

struct v4l2_mbus_framefmt fmt;
struct v4l2_rect crop;

for struct imx214.

After this patch it looks like you have left the driver in a state
where it is using imx214->fmt in imx214_start_streaming() and the
subdev active state in others.

On Mon, Sep 2, 2024 at 11:53 PM André Apitzsch via B4 Relay
<devnull+git.apitzsch.eu@xxxxxxxxxx> wrote:
>
> From: André Apitzsch <git@xxxxxxxxxxx>
>
> Port the imx214 sensor driver to use the subdev active state.
>
> Move all the format configuration to the subdevice state and simplify
> the format handling, locking and initialization.
>
> Signed-off-by: André Apitzsch <git@xxxxxxxxxxx>
> ---
> drivers/media/i2c/imx214.c | 129 +++++++++++++--------------------------------
> 1 file changed, 38 insertions(+), 91 deletions(-)
>
> diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
> index 4962cfe7c83d..58f3c3f67e0d 100644
> --- a/drivers/media/i2c/imx214.c
> +++ b/drivers/media/i2c/imx214.c
> @@ -71,12 +71,6 @@ struct imx214 {
> struct regulator_bulk_data supplies[IMX214_NUM_SUPPLIES];
>
> struct gpio_desc *enable_gpio;
> -
> - /*
> - * Serialize control access, get/set format, get selection
> - * and start streaming.
> - */
> - struct mutex mutex;
> };
>
> struct reg_8 {
> @@ -490,6 +484,22 @@ static int __maybe_unused imx214_power_off(struct device *dev)
> return 0;
> }
>
> +static void imx214_update_pad_format(struct imx214 *imx214,
> + const struct imx214_mode *mode,
> + struct v4l2_mbus_framefmt *fmt, u32 code)
> +{
> + fmt->code = IMX214_MBUS_CODE;
> + fmt->width = mode->width;
> + fmt->height = mode->height;
> + fmt->field = V4L2_FIELD_NONE;
> + fmt->colorspace = V4L2_COLORSPACE_SRGB;
> + fmt->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(fmt->colorspace);
> + fmt->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(true,
> + fmt->colorspace,
> + fmt->ycbcr_enc);
> + fmt->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(fmt->colorspace);
> +}
> +
> static int imx214_enum_mbus_code(struct v4l2_subdev *sd,
> struct v4l2_subdev_state *sd_state,
> struct v4l2_subdev_mbus_code_enum *code)
> @@ -549,52 +559,6 @@ static const struct v4l2_subdev_core_ops imx214_core_ops = {
> #endif
> };
>
> -static struct v4l2_mbus_framefmt *
> -__imx214_get_pad_format(struct imx214 *imx214,
> - struct v4l2_subdev_state *sd_state,
> - unsigned int pad,
> - enum v4l2_subdev_format_whence which)
> -{
> - switch (which) {
> - case V4L2_SUBDEV_FORMAT_TRY:
> - return v4l2_subdev_state_get_format(sd_state, pad);
> - case V4L2_SUBDEV_FORMAT_ACTIVE:
> - return &imx214->fmt;
> - default:
> - return NULL;
> - }
> -}
> -
> -static int imx214_get_format(struct v4l2_subdev *sd,
> - struct v4l2_subdev_state *sd_state,
> - struct v4l2_subdev_format *format)
> -{
> - struct imx214 *imx214 = to_imx214(sd);
> -
> - mutex_lock(&imx214->mutex);
> - format->format = *__imx214_get_pad_format(imx214, sd_state,
> - format->pad,
> - format->which);
> - mutex_unlock(&imx214->mutex);
> -
> - return 0;
> -}
> -
> -static struct v4l2_rect *
> -__imx214_get_pad_crop(struct imx214 *imx214,
> - struct v4l2_subdev_state *sd_state,
> - unsigned int pad, enum v4l2_subdev_format_whence which)
> -{
> - switch (which) {
> - case V4L2_SUBDEV_FORMAT_TRY:
> - return v4l2_subdev_state_get_crop(sd_state, pad);
> - case V4L2_SUBDEV_FORMAT_ACTIVE:
> - return &imx214->crop;
> - default:
> - return NULL;
> - }
> -}
> -
> static int imx214_set_format(struct v4l2_subdev *sd,
> struct v4l2_subdev_state *sd_state,
> struct v4l2_subdev_format *format)
> @@ -604,34 +568,19 @@ static int imx214_set_format(struct v4l2_subdev *sd,
> struct v4l2_rect *__crop;
> const struct imx214_mode *mode;
>
> - mutex_lock(&imx214->mutex);
> -
> - __crop = __imx214_get_pad_crop(imx214, sd_state, format->pad,
> - format->which);
> -
> mode = v4l2_find_nearest_size(imx214_modes,
> ARRAY_SIZE(imx214_modes), width, height,
> format->format.width,
> format->format.height);
>
> - __crop->width = mode->width;
> - __crop->height = mode->height;
> + imx214_update_pad_format(imx214, mode, &format->format, format->format.code);
>
> - __format = __imx214_get_pad_format(imx214, sd_state, format->pad,
> - format->which);
> - __format->width = __crop->width;
> - __format->height = __crop->height;
> - __format->code = IMX214_MBUS_CODE;
> - __format->field = V4L2_FIELD_NONE;
> - __format->colorspace = V4L2_COLORSPACE_SRGB;
> - __format->ycbcr_enc = V4L2_MAP_YCBCR_ENC_DEFAULT(__format->colorspace);
> - __format->quantization = V4L2_MAP_QUANTIZATION_DEFAULT(true,
> - __format->colorspace, __format->ycbcr_enc);
> - __format->xfer_func = V4L2_MAP_XFER_FUNC_DEFAULT(__format->colorspace);
> + __format = v4l2_subdev_state_get_format(sd_state, 0);
> + *__format = format->format;
>
> - format->format = *__format;
> -
> - mutex_unlock(&imx214->mutex);
> + __crop = v4l2_subdev_state_get_crop(sd_state, 0);
> + __crop->width = mode->width;
> + __crop->height = mode->height;
>
> return 0;
> }
> @@ -640,14 +589,9 @@ static int imx214_get_selection(struct v4l2_subdev *sd,
> struct v4l2_subdev_state *sd_state,
> struct v4l2_subdev_selection *sel)
> {
> - struct imx214 *imx214 = to_imx214(sd);
> -
> switch (sel->target) {
> case V4L2_SEL_TGT_CROP:
> - mutex_lock(&imx214->mutex);
> - sel->r = *__imx214_get_pad_crop(imx214, sd_state, sel->pad,
> - sel->which);
> - mutex_unlock(&imx214->mutex);
> + sel->r = *v4l2_subdev_state_get_crop(sd_state, 0);
> return 0;
>
> case V4L2_SEL_TGT_NATIVE_SIZE:
> @@ -829,7 +773,6 @@ static int imx214_start_streaming(struct imx214 *imx214)
> const struct imx214_mode *mode;
> int ret;
>
> - mutex_lock(&imx214->mutex);
> ret = imx214_write_table(imx214, mode_table_common);
> if (ret < 0) {
> dev_err(imx214->dev, "could not sent common table %d\n", ret);
> @@ -855,11 +798,9 @@ static int imx214_start_streaming(struct imx214 *imx214)
> goto error;
> }
>
> - mutex_unlock(&imx214->mutex);
> return 0;
>
> error:
> - mutex_unlock(&imx214->mutex);
> return ret;
> }
>
> @@ -877,6 +818,7 @@ static int imx214_stop_streaming(struct imx214 *imx214)
> static int imx214_s_stream(struct v4l2_subdev *subdev, int enable)
> {
> struct imx214 *imx214 = to_imx214(subdev);
> + struct v4l2_subdev_state *state;
> int ret;
>
> if (enable) {
> @@ -884,7 +826,9 @@ static int imx214_s_stream(struct v4l2_subdev *subdev, int enable)
> if (ret < 0)
> return ret;
>
> + state = v4l2_subdev_lock_and_get_active_state(subdev);
> ret = imx214_start_streaming(imx214);
> + v4l2_subdev_unlock_state(state);
> if (ret < 0)
> goto err_rpm_put;
> } else {
> @@ -948,7 +892,7 @@ static const struct v4l2_subdev_pad_ops imx214_subdev_pad_ops = {
> .enum_mbus_code = imx214_enum_mbus_code,
> .enum_frame_size = imx214_enum_frame_size,
> .enum_frame_interval = imx214_enum_frame_interval,
> - .get_fmt = imx214_get_format,
> + .get_fmt = v4l2_subdev_get_fmt,
> .set_fmt = imx214_set_format,
> .get_selection = imx214_get_selection,
> .get_frame_interval = imx214_get_frame_interval,
> @@ -1083,9 +1027,6 @@ static int imx214_probe(struct i2c_client *client)
> if (ret < 0)
> goto error_power_off;
>
> - mutex_init(&imx214->mutex);
> - imx214->ctrls.lock = &imx214->mutex;
> -
> imx214->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> imx214->pad.flags = MEDIA_PAD_FL_SOURCE;
> imx214->sd.dev = &client->dev;
> @@ -1097,20 +1038,27 @@ static int imx214_probe(struct i2c_client *client)
> goto free_ctrl;
> }
>
> - imx214_entity_init_state(&imx214->sd, NULL);
> + imx214->sd.state_lock = imx214->ctrls.lock;
> + ret = v4l2_subdev_init_finalize(&imx214->sd);
> + if (ret < 0) {
> + dev_err(dev, "subdev init error: %d\n", ret);
> + goto free_entity;
> + }
>
> ret = v4l2_async_register_subdev_sensor(&imx214->sd);
> if (ret < 0) {
> dev_err(dev, "could not register v4l2 device\n");
> - goto free_entity;
> + goto error_subdev_cleanup;
> }
>
> return 0;
>
> +error_subdev_cleanup:
> + v4l2_subdev_cleanup(&imx214->sd);
> +
> free_entity:
> media_entity_cleanup(&imx214->sd.entity);
> free_ctrl:
> - mutex_destroy(&imx214->mutex);
> v4l2_ctrl_handler_free(&imx214->ctrls);
> error_power_off:
> pm_runtime_disable(imx214->dev);
> @@ -1125,13 +1073,12 @@ static void imx214_remove(struct i2c_client *client)
> struct imx214 *imx214 = to_imx214(sd);
>
> v4l2_async_unregister_subdev(&imx214->sd);
> + v4l2_subdev_cleanup(sd);
> media_entity_cleanup(&imx214->sd.entity);
> v4l2_ctrl_handler_free(&imx214->ctrls);
>
> pm_runtime_disable(&client->dev);
> pm_runtime_set_suspended(&client->dev);
> -
> - mutex_destroy(&imx214->mutex);
> }
>
> static const struct of_device_id imx214_of_match[] = {
>
> --
> 2.46.0
>
>

Next message: Ricardo Ribalda Delgado: "Re: [PATCH 02/13] media: i2c: imx214: Remove unneeded goto"
Previous message: Ricardo Ribalda Delgado: "Re: [PATCH 03/13] media: i2c: imx214: Simplify with dev_err_probe()"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]