Re: [PATCH 05/21] KVM: VMX: Teach EPT violation helper about private mem

From: Edgecombe, Rick P
Date: Thu Sep 12 2024 - 10:43:23 EST


On Thu, 2024-09-12 at 06:58 -0700, Sean Christopherson wrote:
> > Which clearly says it is checking the *faulting* GPA.
>
> I don't think that necessarily solves the problem either, because the reader
> has
> to know that the KVM looks at the shared bit.
>
> If open coding is undesirable

Yea, I think it's used in enough places that a helper is worth it.

> , maybe a very literal name, e.g. vmx_is_shared_bit_set()?

Sure, thanks.