Re: [PATCH] selftests: Makefile: add missing 'net/lib' to targets

From: Jakub Kicinski
Date: Thu Sep 12 2024 - 11:23:19 EST


On Thu, 12 Sep 2024 08:31:18 +0200 Anders Roxell wrote:
> Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests")
> Signed-off-by: Anders Roxell <anders.roxell@xxxxxxxxxx>
> ---
> tools/testing/selftests/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
> index 3b7df5477317..fc3681270afe 100644
> --- a/tools/testing/selftests/Makefile
> +++ b/tools/testing/selftests/Makefile
> @@ -64,6 +64,7 @@ TARGETS += net
> TARGETS += net/af_unix
> TARGETS += net/forwarding
> TARGETS += net/hsr
> +TARGETS += net/lib
> TARGETS += net/mptcp
> TARGETS += net/netfilter
> TARGETS += net/openvswitch

Please make sure you always include a commit message. Among other
things writing one would force you to understand the code, and
in this case understand that this target is intentionally left out.
Look around the Makefile for references to net/lib, you'll figure
it out.

The patch is incorrect.