Re: [PATCH v1 1/1] i2c: synquacer: Fix clock rate retrieval code

[Andy Shevchenko]

On Thu, Sep 12, 2024 at 5:49 PM Andi Shyti <andi.shyti@xxxxxxxxxx> wrote:
> On Thu, Sep 12, 2024 at 05:41:05PM GMT, Andy Shevchenko wrote:
> > With the devm_clk_get_enabled() the probe will fail on the systems
> > that have no clock provided, such as ACPI-based ones.
> >
> >     synquacer_i2c SCX0003:00: error -ENOENT: failed to get and enable clock
> >     synquacer_i2c SCX0003:00: probe with driver synquacer_i2c failed with error -2
> >
> > Fix this by switching to devm_clk_get_optional_enabled() in conjunction with NULL
> > check, so we won't overwrite the clock rate from the property.
> >
> > Fixes: 55750148e559 ("i2c: synquacer: Fix an error handling path in synquacer_i2c_probe()")
> > Reported-by: Ard Biesheuvel <ardb@xxxxxxxxxx>
> > Closes: https://lore.kernel.org/r/CAMj1kXFH+zB_YuUS+vaEpguhuVGLYbQw55VNDCxnBfSPe6b-nw@xxxxxxxxxxxxxx
> > Signed-off-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
>
> you are late, Ard already sent the fix :-)

Ah, and it's identical! Means it's good as is :-)


-- 
With Best Regards,
Andy Shevchenko