Re: [PATCH v2] net: ethernet: ag71xx: Remove dead code

[Eric Dumazet]

On Wed, Sep 11, 2024 at 8:20 PM Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx> wrote:
>
> On Wed, Sep 11, 2024 at 06:58:27PM +0500, Muhammad Usama Anjum wrote:
> > The err variable isn't being used anywhere other than getting
> > initialized to 0 and then it is being checked in if condition. The
> > condition can never be true. Remove the err and deadcode.
> >
> > Move the rx_dropped counter above when skb isn't found.
> >
> > Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> > Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
>
> Reviewed-by: Oleksij Rempel <o.rempel@xxxxxxxxxxxxxx>
>
> Thank you!
>
> Regards,
> Oleksij

I do not see any credits given to  Qianqiang Liu, who is desperate to get his
first linux patch...

https://lore.kernel.org/netdev/20240910152254.21238-1-qianqiang.liu@xxxxxxx/