Re: [PATCH v2] SLUB: Add support for per object memory policies

[Matthew Wilcox]

On Thu, Sep 12, 2024 at 09:15:34AM -0700, Christoph Lameter (Ampere) wrote:
> > sparse warnings: (new ones prefixed by >>)
> > >> mm/slub.c:222:1: sparse: sparse: symbol 'strict_numa' was not declared. Should it be static?
> 
> 
> Ummm.. This code declares strict_numa. Whats wrong with sparc64 / sparse ?
> 
> > vim +/strict_numa +222 mm/slub.c
> >
> >    220
> >    221	#ifdef CONFIG_NUMA
> >  > 222	DEFINE_STATIC_KEY_FALSE(strict_numa);

maybe this should be:

static DEFINE_STATIC_KEY_FALSE(strict_numa);

if it's only used within mm/slub.c?  Or it needs to be declared in a
header file if it is used outside mm/slub.c.

> >    223	#endif
> >    224
> >
> 
>