Re: [RFC PATCH for-next] pm: cpupower: rename raw_pylibcpupower.i

[Shuah Khan]

On 9/12/24 11:36, John B. Wyatt IV wrote:
> On Thu, Sep 12, 2024 at 10:31:19AM -0600, Shuah Khan wrote:
> > On 9/12/24 06:50, Min-Hua Chen wrote:
> > > This RFC patch is actually bug report. All *.i file will be
> > > removed by 'make mrproper', including raw_pylibcpupower.i, added
> > > by commit: 338f490e07bc ("pm:cpupower: Add SWIG bindings files for libcpupower")
> > >
> > > We can reproduce the error by performing the following command:
> > > cd linux-next
> > > make mrproper
> > > cd tools/power/cpupower/bindings/python
> > > make
> > >
> > > We will get an error message:
> > > make: *** No rule to make target 'raw_pylibcpupower.i', needed by 'raw_pylibcpupower_wrap.c'.  Stop.
> > >
> > > Renaming the raw_pylibcpupower.i is just a workaround to fix the
> > > issue above.
> >
> > I need a non-rfc patch for this. Please send a proper patch
> > I can pull in once John has a chance to review this.

How and when is raw_pylibcpupower.i generated? This looks
like a pre-processor output.


> I have reviewed and tested and this. I am good with it being a stopgap.

I am okay with the stopgap, but I do want i explore other solutions.
> Please send the non-rfc patch.
>
> Thank you for reporting and sending a patch for this Min-Hua.
>
> Reviewed-by: John B. Wyatt IV <jwyatt@xxxxxxxxxx>
> Reviewed-by: John B. Wyatt IV <sageofredondo@xxxxxxxxx>
> Tested-by: John B. Wyatt IV <jwyatt@xxxxxxxxxx>
> Tested-by: John B. Wyatt IV <sageofredondo@xxxxxxxxx>

thanks,
-- Shuah