Re: [PATCH v4 0/5] Support alpha blending in MTK display driver

From: CK Hu (胡俊光)
Date: Thu Sep 12 2024 - 21:25:43 EST


Hi, Jason:

Please help to fix this issue.
Otherwise, I would revert this series.

Regards,
CK

On Thu, 2024-09-12 at 23:29 +0300, Alper Nebi Yasak wrote:
>
> External email : Please do not click links or open attachments until you have verified the sender or the content.
> Hi,
>
> On 2024-07-31 16:34 +03:00, Chun-Kuang Hu wrote:
> > Hi, Shawn:
> >
> > Hsiao Chien Sung via B4 Relay
> > <devnull+shawn.sung.mediatek.com@xxxxxxxxxx> 於 2024年7月17日 週三 下午1:24寫道:
> >>
> >> Support "Pre-multiplied" and "None" blend mode on MediaTek's chips by
> >> adding correct blend mode property when the planes init.
> >> Before this patch, only the "Coverage" mode (default) is supported.
> >
> > For the whole series, applied to mediatek-drm-next [1], thanks.
> >
> > [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next
>
> I am seeing broken colors on an MT8173 Chromebook with next-20240912,
> which goes away if I git-revert this series (commits 1f66fe62cc09
> eb17c5909481 a3f7f7ef4bfe 59e9d9de25f0 4225d5d5e779).
>
> To illustrate, I took a picture [1] of some color mixing diagrams from
> Wikipedia [2]. Do you have an idea of what goes wrong?
>
> (I'm busy with too many things so I don't want to debug it now...)
>
> [1] https://i.imgur.com/tNFvovB.jpeg
> [2] https://en.wikipedia.org/wiki/Color_space#Generic
>