Re: [PATCH net-next] net: ethtool: phy: Clear the netdev context pointer for DUMP requests

From: Jakub Kicinski
Date: Thu Sep 12 2024 - 23:44:55 EST


On Wed, 11 Sep 2024 15:46:21 +0200 Maxime Chevallier wrote:
> + /* Clear the context netdev pointer so avoid a netdev_put from
> + * the .done() callback
> + */
> + ctx->phy_req_info->base.dev = NULL;

Why do we assign to req_base.dev in the first place?
req is for the parsed request in my mind, and I don't
see anything in the PHY dump handlers actually using dev?