Re: [PATCH] usb: xhci: fix loss of data on Cadence xHC

[Mathias Nyman]

On 12.9.2024 18.53, Andy Shevchenko wrote:
> Thu, Sep 05, 2024 at 07:06:48AM +0000, Pawel Laszczak kirjoitti:
> > Please ignore this patch. I send it again with correct version in subject.
>
> It seems it's in Mathias' tree, never the less, see also below.
>
> ...
>
> > > +#define PCI_DEVICE_ID_CADENCE				0x17CD
>
> First of all this is misleadig as this is VENDOR_ID, second, there is official
> ID constant for Cadence in pci_ids.h.
>
> #define PCI_VENDOR_ID_CDNS              0x17cd

Thanks, fixed and rebased.

Changes:

diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
index 5e7747f80762..4bc6ee57ec42 100644
--- a/drivers/usb/host/xhci-pci.c
+++ b/drivers/usb/host/xhci-pci.c
@@ -78,8 +78,7 @@
 #define PCI_DEVICE_ID_ASMEDIA_2142_XHCI                        0x2142
 #define PCI_DEVICE_ID_ASMEDIA_3242_XHCI                        0x3242
 
-#define PCI_DEVICE_ID_CADENCE                          0x17CD
-#define PCI_DEVICE_ID_CADENCE_SSP                      0x0200
+#define PCI_DEVICE_ID_CDNS_SSP                         0x0200
 
 static const char hcd_name[] = "xhci_hcd";
 
@@ -470,8 +469,8 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
                        xhci->quirks |= XHCI_ZHAOXIN_TRB_FETCH;
        }
 
-       if (pdev->vendor == PCI_DEVICE_ID_CADENCE &&
-           pdev->device == PCI_DEVICE_ID_CADENCE_SSP)
+       if (pdev->vendor == PCI_VENDOR_ID_CDNS &&
+           pdev->device == PCI_DEVICE_ID_CDNS_SSP)
                xhci->quirks |= XHCI_CDNS_SCTX_QUIRK;
-Mathias