Re: [PATCH v2] smb: client: compress: fix an "illegal accesses" issue

[Dan Carpenter]

On Fri, Sep 13, 2024 at 11:27:51AM +0800, Qianqiang Liu wrote:
> Using uninitialized value "bkt" when calling "kfree"
> 
> Fixes: 13b68d44990d9 ("smb: client: compress: LZ77 code improvements cleanup")
> Signed-off-by: Qianqiang Liu <qianqiang.liu@xxxxxxx>

Thanks.

Reviewed-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>

I was reviewing this static checker warning.  I also have an unpublished warning
which complains about collect_sample().

fs/smb/client/compress.c:207 collect_sample() warn: should we be adding 'len' of the min_t value?

It's a bit weird to sample data from each page.  Could we add some comments at
the top of the function explaining what the function does.

/*
 * This reads a 2k sample from the start of each page to see the data is already
 * compressed or whether we can compress it further.
 */

regards,
dan carpenter