Re: [PATCH net-next v3 1/2] netpoll: Make netpoll_send_udp return status instead of void

[Breno Leitao]

On Thu, Sep 12, 2024 at 10:28:51AM -0700, Maksym Kutsevol wrote:
> netpoll_send_udp can return if send was successful.
> It will allow client code to be aware of the send status.
> 
> Possible return values are the result of __netpoll_send_skb (cast to int)
> and -ENOMEM. This doesn't cover the case when TX was not successful
> instantaneously and was scheduled for later, __netpoll__send_skb returns
> success in that case.
> 
> Signed-off-by: Maksym Kutsevol <max@xxxxxxxxxxxx>

Reviewed-by: Breno Leitao <leitao@xxxxxxxxxx>

Thanks for addressing it. Two things you might want to consider:

1) There are some warnings related to this patch.
 a) Not CCed maintainers
 b) WARNING: line length of 95 exceeds 80 columns

You can see them here:
https://patchwork.kernel.org/project/netdevbpf/patch/20240912173608.1821083-2-max@xxxxxxxxxxxx/

Also, this might conflict with the refactor I did a while ago, so, you
might need to rebase:

https://lore.kernel.org/all/20240910100410.2690012-1-leitao@xxxxxxxxxx/

Other than that, I am happy with it.

Thanks for doing it
-breno